Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: use a slim way to build docker image on latest code & support zgc (#2118) #2297

Merged
merged 1 commit into from
Aug 26, 2023
Merged

refact: use a slim way to build docker image on latest code & support zgc (#2118) #2297

merged 1 commit into from
Aug 26, 2023

Conversation

aroundabout
Copy link
Contributor

Purpose of the PR

Main Changes

  1. based on the branch release-1.0.0
  2. cherry pick the commit about the update of docker file. The commit is from refact: use a slim way to build docker image on latest code & support zgc #2118

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (github action ci).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Aug 26, 2023 •
edited
Loading

Codecov Report

Merging #2297 (1c50cef) into docker-1.0.0 (c8e0f0c) will decrease coverage by 0.75%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             docker-1.0.0    #2297      +/-   ##
==================================================
- Coverage           69.38%   68.63%   -0.75%     
  Complexity            977      977              
==================================================
  Files                 479      479              
  Lines               39655    39655              
  Branches             5578     5578              
==================================================
- Hits                27513    27219     -294     
- Misses               9489     9790     +301     
+ Partials             2653     2646       -7

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin merged commit 7a085ff into apache:docker-1.0.0 Aug 26, 2023
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aroundabout @imbajin